[coreboot-gerrit] Change in coreboot[master]: [Do Not Merge] add i945G based mainboard

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 )

Change subject: [Do Not Merge] add i945G based mainboard
......................................................................


Patch Set 22:

(17 comments)

https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c
File src/mainboard/nec/945g-m4/romstage.c:

https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@140
PS22, Line 140: 	[   16.101663] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x2
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@141
PS22, Line 141: 	[   16.101785] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x2
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@142
PS22, Line 142: 	[   16.101859] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@143
PS22, Line 143: 	[   16.101974] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@144
PS22, Line 144: 	[   16.102086] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@145
PS22, Line 145: 	[   16.102156] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x38
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@146
PS22, Line 146: 	[   16.102250] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x38
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@147
PS22, Line 147: 	[   16.103089] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x10
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.c@151
PS22, Line 151: 	[   11.645291] snd_intel8x0m: probe of 0000:00:1e.3 failed with error -13
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c
File src/mainboard/nec/945g-m4/superio_hwm.c:

https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@83
PS22, Line 83: 	//if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS)
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@90
PS22, Line 90: 	//if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS)
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@135
PS22, Line 135: 		hwm_write(0x06, fan_speeds[cpufan_speed].fan_in);  // CPUFANIN target speed
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@140
PS22, Line 140: 				temperatures[cpufan_temperature].deg_fahrenheit);
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@141
PS22, Line 141: 		hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius);  // CPUFANIN target temperature
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@149
PS22, Line 149: 		hwm_write(0x05, fan_speeds[sysfan_speed].fan_in);  // SYSFANIN target speed
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@154
PS22, Line 154: 				temperatures[sysfan_temperature].deg_fahrenheit);
line over 80 characters


https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_hwm.c@155
PS22, Line 155: 		hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature
line over 80 characters



-- 
To view, visit https://review.coreboot.org/25509
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3
Gerrit-Change-Number: 25509
Gerrit-PatchSet: 22
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 17:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180731/83c0338f/attachment.html>