[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Winbond specific write-protection enable

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 )

Change subject: drivers/spi: Winbond specific write-protection enable
......................................................................


Patch Set 7:

(4 comments)

https://review.coreboot.org/#/c/25105/7/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:

https://review.coreboot.org/#/c/25105/7/src/drivers/spi/winbond.c@39
PS7, Line 39: #define CMD_VOLTILE_SREG_WREN	0x50	/* Write Enable for Volatile Status Register */
line over 80 characters


https://review.coreboot.org/#/c/25105/7/src/drivers/spi/winbond.c@82
PS7, Line 82: 		u8      : 5;
space prohibited before that ':' (ctx:WxW)


https://review.coreboot.org/#/c/25105/7/src/drivers/spi/winbond.c@84
PS7, Line 84: 		u8      : 1;
space prohibited before that ':' (ctx:WxW)


https://review.coreboot.org/#/c/25105/7/src/drivers/spi/winbond.c@568
PS7, Line 568: 	       "0x%08zx-0x%08zx\n",region->offset, region->size);
space required after that ',' (ctx:VxV)



-- 
To view, visit https://review.coreboot.org/25105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3765b013855538eca37bc7800d3f9d5d09b8402
Gerrit-Change-Number: 25105
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 14:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180731/6a75e0c1/attachment.html>