[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Force USB-C into host mode

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Jul 30 23:48:26 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27746 )

Change subject: soc/intel/apollolake: Force USB-C into host mode
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/27746/2/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/27746/2/src/soc/intel/apollolake/chip.c@676
PS2, Line 676: 		if (IS_ENABLED(CONFIG_SOC_INTEL_GLK) && vboot_can_enable_udc())
that open brace { should be on the previous line


https://review.coreboot.org/#/c/27746/2/src/soc/intel/apollolake/chip.c@698
PS2, Line 698: 			while ((read32(cfg1) & DRD_MODE_MASK) != DRD_MODE_HOST)
that open brace { should be on the previous line



-- 
To view, visit https://review.coreboot.org/27746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca3d25a1159f922b743963cbc508d8defa7b6ff
Gerrit-Change-Number: 27746
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 30 Jul 2018 21:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/5264a02f/attachment.html>


More information about the coreboot-gerrit mailing list