[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Force USB-C into host mode

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Jul 30 23:16:04 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27746 )

Change subject: soc/intel/apollolake: Force USB-C into host mode
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@673
PS1, Line 673: 		 * When USB OTG is set, GLK FSP enables xHCI SW ID pin and configures
line over 80 characters


https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@676
PS1, Line 676: 		if (IS_ENABLED(CONFIG_SOC_INTEL_GLK) && vboot_can_enable_udc()) {
line over 80 characters


https://review.coreboot.org/#/c/27746/1/src/soc/intel/apollolake/chip.c@697
PS1, Line 697: 			while ((read32(cfg1) & DRD_MODE_MASK) != DRD_MODE_HOST) {
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca3d25a1159f922b743963cbc508d8defa7b6ff
Gerrit-Change-Number: 27746
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 30 Jul 2018 21:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/7f31385e/attachment.html>


More information about the coreboot-gerrit mailing list