[coreboot-gerrit] Change in coreboot[master]: security/vboot: Enable TCPA log extension

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27727 )

Change subject: security/vboot: Enable TCPA log extension
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c@181
PS2, Line 181: uint32_t tpm_extend_pcr(const char *name, int pcr, uint8_t *digest,
i'd prefer "const char *name" to be the last argument, as it's only required for logging.


https://review.coreboot.org/#/c/27727/2/src/security/tpm/tspi/tspi.c@195
PS2, Line 195: 		printk(BIOS_ERR, "ERROR: Couldn't creat TCPA log entry\n");
create


https://review.coreboot.org/#/c/27727/2/src/security/vboot/secdata_tpm.c
File src/security/vboot/secdata_tpm.c:

https://review.coreboot.org/#/c/27727/2/src/security/vboot/secdata_tpm.c@83
PS2, Line 83: 		return tpm_extend_pcr("GBB flags", pcr, buffer, size);
do you want to use defines for the TCPA log entries in a public header ?



-- 
To view, visit https://review.coreboot.org/27727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22b1aa8da1a95380c39715727615ce5ce4c9443f
Gerrit-Change-Number: 27727
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 30 Jul 2018 07:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/d43e1357/attachment.html>