[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon Jul 30 08:12:11 CEST 2018


Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/27661 )

Change subject: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default
......................................................................

mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default

Currently, default GPP_D21(LTE3_BODY_SAR) output level is low, it means
LTE tx power is backoff mode as default.

We would set GPP_D21 to high to change LTE tx power to normal mode as
default.

BUG=None
BRANCH=poppy
TEST=Verified default LTE tx power mode is normal mode as default

Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
Reviewed-on: https://review.coreboot.org/27661
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nautilus/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Seunghwan Kim: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index 8b129d1..75d4ce9 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -395,7 +395,7 @@
 	/* D16 : ISH_UART0_CTS# ==> LTE3_W_DISABLE# */
 	PAD_CFG_GPO(GPP_D16, 1, DEEP),
 	/* D21 : SPI1_IO2 ==> LTE3_BODY_SAR */
-	PAD_CFG_GPO(GPP_D21, 0, DEEP),
+	PAD_CFG_GPO(GPP_D21, 1, DEEP),
 	/* E11 : USB2_OC2# ==> USB2_P2_FAULT# */
 	PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),
 };

-- 
To view, visit https://review.coreboot.org/27661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c
Gerrit-Change-Number: 27661
Gerrit-PatchSet: 4
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/66265c1f/attachment.html>


More information about the coreboot-gerrit mailing list