[coreboot-gerrit] Change in coreboot[master]: mb/samsung/lumpy/smihandler: Use new PMBASE API

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27680


Change subject: mb/samsung/lumpy/smihandler: Use new PMBASE API
......................................................................

mb/samsung/lumpy/smihandler: Use new PMBASE API

Change-Id: I82287e52cf637381becfd27301d562e7829bb665
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/mainboard/samsung/lumpy/smihandler.c
1 file changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/27680/1

diff --git a/src/mainboard/samsung/lumpy/smihandler.c b/src/mainboard/samsung/lumpy/smihandler.c
index 9690aee..f2c2dc3 100644
--- a/src/mainboard/samsung/lumpy/smihandler.c
+++ b/src/mainboard/samsung/lumpy/smihandler.c
@@ -19,6 +19,7 @@
 #include <southbridge/intel/bd82x6x/nvs.h>
 #include <southbridge/intel/bd82x6x/pch.h>
 #include <southbridge/intel/bd82x6x/me.h>
+#include <southbridge/intel/common/pmbase.h>
 #include <northbridge/intel/sandybridge/sandybridge.h>
 #include <cpu/intel/model_206ax/model_206ax.h>
 #include <ec/smsc/mec1308/ec.h>
@@ -27,7 +28,6 @@
 static u8 mainboard_smi_ec(void)
 {
 	u8 cmd;
-	u32 pm1_cnt;
 
 	cmd = read_ec_command_byte(EC_GET_SMI_CAUSE);
 
@@ -36,9 +36,7 @@
 		printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");
 
 		/* Go to S5 */
-		pm1_cnt = inl(smm_get_pmbase() + PM1_CNT);
-		pm1_cnt |= (0xf << 10);
-		outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);
+		write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));
 		break;
 	}
 

-- 
To view, visit https://review.coreboot.org/27680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82287e52cf637381becfd27301d562e7829bb665
Gerrit-Change-Number: 27680
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180728/2f5a98d8/attachment.html>