[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Pad SPD serial Number with spaces

Martin Roth (Code Review) gerrit at coreboot.org
Sat Jul 28 06:56:12 CEST 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27676


Change subject: mainboard/google/kahlee: Pad SPD serial Number with spaces
......................................................................

mainboard/google/kahlee: Pad SPD serial Number with spaces

All of the other SPDs are padded with spaces to make them use the full
size of the serial number field.  The hynix-H5AN8G6NCJR-VKC SPD was not,
and that seems to be causing problems with some tools.

BUG=b:111903749
TEST=Mosys correctly identifies memory on board using that SPD.

Change-Id: I0e831873acab2f6fc7d76e85647198d3b7af4b12
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/27676/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex
index 1bcc1f1..3d046a3 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex
+++ b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex
@@ -20,7 +20,7 @@
 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
 80 AD 01 00 00 00 00 00  00 48 35 41 4E 38 47 36
-4E 43 4A 52 2D 56 4B 43  00 00 00 00 00 00 00 00
+4E 43 4A 52 2D 56 4B 43  20 20 20 20 00 00 00 00
 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00

-- 
To view, visit https://review.coreboot.org/27676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e831873acab2f6fc7d76e85647198d3b7af4b12
Gerrit-Change-Number: 27676
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180728/0954acfa/attachment.html>


More information about the coreboot-gerrit mailing list