[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu2/mainboard.c: enable power on after fail

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Jul 27 13:36:07 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27663 )

Change subject: mb/pcengines/apu2/mainboard.c: enable power on after fail
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/27663/1/src/mainboard/pcengines/apu2/mainboard.c
File src/mainboard/pcengines/apu2/mainboard.c:

https://review.coreboot.org/#/c/27663/1/src/mainboard/pcengines/apu2/mainboard.c@181
PS1, Line 181: 	pm_write8 ( PM_RTC_SHADOW, pm_read8( PM_RTC_SHADOW ) | (1 << 0));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27663/1/src/mainboard/pcengines/apu2/mainboard.c@181
PS1, Line 181: 	pm_write8 ( PM_RTC_SHADOW, pm_read8( PM_RTC_SHADOW ) | (1 << 0));
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/27663/1/src/mainboard/pcengines/apu2/mainboard.c@181
PS1, Line 181: 	pm_write8 ( PM_RTC_SHADOW, pm_read8( PM_RTC_SHADOW ) | (1 << 0));
space prohibited before that close parenthesis ')'



-- 
To view, visit https://review.coreboot.org/27663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b35db16e2090484e58d1307dc29049a1325c65f
Gerrit-Change-Number: 27663
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 27 Jul 2018 11:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/f8bb7445/attachment.html>


More information about the coreboot-gerrit mailing list