[coreboot-gerrit] Change in coreboot[master]: google/caroline: Change debounce time for jack insertion and ejection
Matt DeVillier (Code Review)
gerrit at coreboot.org
Fri Jul 27 07:36:23 CEST 2018
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/27659
Change subject: google/caroline: Change debounce time for jack insertion and ejection
......................................................................
google/caroline: Change debounce time for jack insertion and ejection
Adapted from chromium commit 7633daa
[caroline: Change debounce time for jack insertion and ejection]
We are using max debounce time. During this time line, MICBIAS will be
zero because of jack chasis. At the moment we got 0 button(PLAY/PAUSE)
We need to reduce this time within 100ms for caroline device.
BUG=b:79559096
TEST=see there is no more irq before jack insertion/ejection irq
complete
Original-Change-Id: Ib6abdb4ff041823ca89f74cf59e2bfa644bb0d6a
Original-Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/1143109
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Original-Tested-by: Wonjoon Lee <woojoo.lee at samsung.com>
Change-Id: I8f605989d6ffc8a75127ed6722e7a37db95029ed
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/glados/variants/caroline/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27659/1
diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb
index a040714..0c3c861 100644
--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb
+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb
@@ -244,8 +244,8 @@
register "sar_compare_time" = "0" # 500ns
register "sar_sampling_time" = "0" # 2us
register "short_key_debounce" = "2" # 100ms
- register "jack_insert_debounce" = "7" # 512ms
- register "jack_eject_debounce" = "7" # 512ms
+ register "jack_insert_debounce" = "4" # 64ms
+ register "jack_eject_debounce" = "4" # 64ms
device i2c 1a on end
end
chip drivers/i2c/generic
--
To view, visit https://review.coreboot.org/27659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f605989d6ffc8a75127ed6722e7a37db95029ed
Gerrit-Change-Number: 27659
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/c4c9fc8f/attachment.html>
More information about the coreboot-gerrit
mailing list