[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nami: update AC/DC LoadLine in devicetree

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Jul 27 02:26:36 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27646 )

Change subject: mb/google/poppy/variant/nami: update AC/DC LoadLine in devicetree
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27646/2/src/mainboard/google/poppy/variants/nami/mainboard_.c
File src/mainboard/google/poppy/variants/nami/mainboard_.c:

https://review.coreboot.org/#/c/27646/2/src/mainboard/google/poppy/variants/nami/mainboard_.c@205
PS2, Line 205: 		break;
break is not useful after a goto or return



-- 
To view, visit https://review.coreboot.org/27646
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a022a66a6fe478d20f902e9c2c4d5b26bae6c72
Gerrit-Change-Number: 27646
Gerrit-PatchSet: 2
Gerrit-Owner: TH Lin <t.h_lin at quanta.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 27 Jul 2018 00:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/dd0c387a/attachment.html>


More information about the coreboot-gerrit mailing list