[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable ec host event wake

Nick Vaccaro (Code Review) gerrit at coreboot.org
Thu Jul 26 23:23:47 CEST 2018


Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27649 )

Change subject: mb/google/poppy/variants/nocturne: enable ec host event wake
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h
File src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h:

https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h@36
PS1, Line 36: 	 EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\
> You also need to add EC_HOST_EVENT_MODE_CHANGE to SCI list.
Done



-- 
To view, visit https://review.coreboot.org/27649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb
Gerrit-Change-Number: 27649
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 26 Jul 2018 21:23:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180726/fba0b712/attachment.html>


More information about the coreboot-gerrit mailing list