[coreboot-gerrit] Change in coreboot[master]: Documenation/conf.py: Make sure release is a string
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Thu Jul 26 13:16:02 CEST 2018
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/27630 )
Change subject: Documenation/conf.py: Make sure release is a string
......................................................................
Documenation/conf.py: Make sure release is a string
With python3 the split method can operate on strings while check_output
generates bytestrings.
Change-Id: I7b455c56e8195f0ecfbe5e360ac161c176f00115
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/27630
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M Documentation/conf.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Philipp Deppenwiese: Looks good to me, approved
diff --git a/Documentation/conf.py b/Documentation/conf.py
index b8415c6..ff1ad9d 100644
--- a/Documentation/conf.py
+++ b/Documentation/conf.py
@@ -20,7 +20,7 @@
# built documents.
#
# The full version, including alpha/beta/rc tags.
-release = subprocess.check_output(('git', 'describe'))
+release = subprocess.check_output(('git', 'describe')).decode("utf-8")
# The short X.Y version.
version = release.split("-")[0]
--
To view, visit https://review.coreboot.org/27630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b455c56e8195f0ecfbe5e360ac161c176f00115
Gerrit-Change-Number: 27630
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180726/d410ba3f/attachment.html>
More information about the coreboot-gerrit
mailing list