[coreboot-gerrit] Change in coreboot[master]: mb/google/octopusi/variants/bip: Fix unused pins and those with exter...

Thu Jul 26 01:44:30 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27634 )

Change subject: mb/google/octopusi/variants/bip: Fix unused pins and those with external terminations
......................................................................

Patch Set 2:

(23 comments)

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@96
PS2, Line 96: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, TxLASTRxE, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@131
PS2, Line 131: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@133
PS2, Line 133: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@134
PS2, Line 134: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@137
PS2, Line 137: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@141
PS2, Line 141: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@147
PS2, Line 147: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@148
PS2, Line 148: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_BATLOW_B */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@166
PS2, Line 166: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@167
PS2, Line 167: 	PAD_CFG_GPI_SCI_LOW(GPIO_117, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE1_B -- LTE_WAKE_L */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@176
PS2, Line 176: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@179
PS2, Line 179: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@198
PS2, Line 198: 	PAD_CFG_GPI_APIC_IOS(GPIO_135, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@202
PS2, Line 202: 	PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@203
PS2, Line 203: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@206
PS2, Line 206: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@228
PS2, Line 228: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@230
PS2, Line 230: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@238
PS2, Line 238: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_B1 */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@241
PS2, Line 241: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_175, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_DATA_2 */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@269
PS2, Line 269: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@279
PS2, Line 279: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

https://review.coreboot.org/#/c/27634/2/src/mainboard/google/octopus/variants/bip/gpio.c@306
PS2, Line 306: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

-- 
To view, visit https://review.coreboot.org/27634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I343fed54ebc04199acecab257d7b8253d0a3d83b
Gerrit-Change-Number: 27634
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 25 Jul 2018 23:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180725/059895b4/attachment.html>