[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Fix unused pins and those with external terminations

Wed Jul 25 18:02:43 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27183 )

Change subject: mb/google/octopus: Fix unused pins and those with external terminations
......................................................................

Patch Set 5:

(22 comments)

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@98
PS5, Line 98: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, TxLASTRxE, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@133
PS5, Line 133: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@135
PS5, Line 135: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@136
PS5, Line 136: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@139
PS5, Line 139: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@143
PS5, Line 143: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@149
PS5, Line 149: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@150
PS5, Line 150: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_BATLOW_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@168
PS5, Line 168: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@169
PS5, Line 169: 	PAD_CFG_GPI_SCI_LOW(GPIO_117, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE1_B -- LTE_WAKE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@181
PS5, Line 181: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@200
PS5, Line 200: 	PAD_CFG_GPI_APIC_IOS(GPIO_135, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@204
PS5, Line 204: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@207
PS5, Line 207: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@226
PS5, Line 226: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, Tx1RXDCRx0, DISPUPD), /* AVS_I2S1_MCLK -- LTE_OFF_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@229
PS5, Line 229: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@231
PS5, Line 231: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@239
PS5, Line 239: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_B1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@242
PS5, Line 242: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_175, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_DATA_2 */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@270
PS5, Line 270: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@280
PS5, Line 280: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

https://review.coreboot.org/#/c/27183/5/src/mainboard/google/octopus/variants/baseboard/gpio.c@307
PS5, Line 307: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

-- 
To view, visit https://review.coreboot.org/27183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec62913b0ef47105289838218f5d74c004223c
Gerrit-Change-Number: 27183
Gerrit-PatchSet: 5
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Peichao Li <peichao.wang at bitland.corp-partner.google.com>
Gerrit-Reviewer: Peter Lin <peterlin at ami.corp-partner.google.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 25 Jul 2018 16:02:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180725/334ecaf0/attachment.html>