[coreboot-gerrit] Change in coreboot[master]: nb/amd/pi/00730F01: Add initial native IVRS support

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Jul 25 01:55:07 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 )

Change subject: nb/amd/pi/00730F01: Add initial native IVRS support
......................................................................


Patch Set 21:

(4 comments)

https://review.coreboot.org/#/c/15164/21/src/northbridge/amd/pi/00730F01/northbridge.c
File src/northbridge/amd/pi/00730F01/northbridge.c:

https://review.coreboot.org/#/c/15164/21/src/northbridge/amd/pi/00730F01/northbridge.c@507
PS21, Line 507: 				is_pcie = pci_find_capability(dev, PCI_CAP_ID_PCIE);
line over 80 characters


https://review.coreboot.org/#/c/15164/21/src/northbridge/amd/pi/00730F01/northbridge.c@528
PS21, Line 528: 				} else if ((header_type == PCI_HEADER_TYPE_NORMAL) &&
line over 80 characters


https://review.coreboot.org/#/c/15164/21/src/northbridge/amd/pi/00730F01/northbridge.c@608
PS21, Line 608: 		printk(BIOS_WARNING, "%s: G-series northbridge device not present!\n", __func__);
line over 80 characters


https://review.coreboot.org/#/c/15164/21/src/northbridge/amd/pi/00730F01/northbridge.c@609
PS21, Line 609: 		printk(BIOS_WARNING, "%s: IVRS table not generated...\n", __func__);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/15164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae789f75363435accd14a1b556e1570f43f94c4
Gerrit-Change-Number: 15164
Gerrit-PatchSet: 21
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 23:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180724/44d726b6/attachment.html>


More information about the coreboot-gerrit mailing list