[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Jul 24 01:32:15 CEST 2018


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27613 )

Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27613/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27613/1//COMMIT_MSG@9
PS1, Line 9: optional
Can you please add a comment here indicating that the params are optional: https://review.coreboot.org/cgit/coreboot.git/tree/src/drivers/i2c/da7219/chip.h?id=refs/heads/master#n33



-- 
To view, visit https://review.coreboot.org/27613
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Gerrit-Change-Number: 27613
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 23:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/3afe14a6/attachment.html>


More information about the coreboot-gerrit mailing list