[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: permit Kconfig to set subsystem ID

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27609 )

Change subject: soc/intel/skylake: permit Kconfig to set subsystem ID
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

With this change there are two different methods to have FSP configure subsystemID (Kconfig and devicetree) and another one from devicetree with .set_subsystem pci ops? Why?

https://review.coreboot.org/#/c/27609/1/src/soc/intel/skylake/chip_fsp20.c
File src/soc/intel/skylake/chip_fsp20.c:

https://review.coreboot.org/#/c/27609/1/src/soc/intel/skylake/chip_fsp20.c@380
PS1, Line 380: ifdef
> The IS_ENABLED only works with boolean parameters, and this setting is the actual value of the vendo […]
sorry overlooked that...



-- 
To view, visit https://review.coreboot.org/27609
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f7bb8e465f55e5dd6d8e0fad71b9b2a22f089dc
Gerrit-Change-Number: 27609
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 21:09:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/8250a8e2/attachment.html>