[coreboot-gerrit] Change in coreboot[master]: nb/amd/pi/00730F01: use MMIO and performance counters from AGESA

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27602 )

Change subject: nb/amd/pi/00730F01: use MMIO and performance counters from AGESA
......................................................................


Patch Set 1:

(7 comments)

https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c
File src/northbridge/amd/pi/00730F01/northbridge.c:

https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@635
PS1, Line 635: 		ivrs->ivhd.flags |= 0x10;					/* Enable ATS support */
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@637
PS1, Line 637: 		ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8);	/* BDF <bus>:00.2 */
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@638
PS1, Line 638: 		ivrs->ivhd.capability_offset = 0x40;				/* Capability block 0x40 (type 0xf, "Secure device") */
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@648
PS1, Line 648: 		ivrs->ivhd.iommu_feature_info = ivrs_agesa->ivhd.iommu_feature_info & 0x7fe000;
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@653
PS1, Line 653: 		ivrs->ivhd.flags |= 0x10;					/* Enable ATS support */
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@655
PS1, Line 655: 		ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8);	/* BDF <bus>:00.2 */
line over 80 characters


https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/northbridge.c@656
PS1, Line 656: 		ivrs->ivhd.capability_offset = 0x40;				/* Capability block 0x40 (type 0xf, "Secure device") */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e3a3d21f295ae96962d7718b9568fc4b67eb23d
Gerrit-Change-Number: 27602
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 13:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/06382d0f/attachment.html>