[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/da7219: Add vddio property

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27561 )

Change subject: drivers/i2c/da7219: Add vddio property
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27561/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27561/1//COMMIT_MSG@17
PS1, Line 17: 
Needs a signed-off-by line


https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h
File src/drivers/i2c/da7219/chip.h:

https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h@33
PS1, Line 33: 	unsigned vddio;
> Thank you for the advice Jenkins, but I was keeping consistent with the rest of this file here.
As I was reminded yesterday, consistency is the hallmark of excellence.  I guess I can push a follow-on patch to fix it across the board.



-- 
To view, visit https://review.coreboot.org/27561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87ff6e22e2d38e984a8fd7f8434e3f55fd3def24
Gerrit-Change-Number: 27561
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 21 Jul 2018 00:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180721/aa8488f4/attachment.html>