[coreboot-gerrit] Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 )

Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
......................................................................


Patch Set 15:

(13 comments)

https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c
File src/cpu/intel/speedstep/acpi.c:

https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@68
PS15, Line 68: 		if ( c.x86_model ==2)
spaces required around that '==' (ctx:WxV)


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@68
PS15, Line 68: 		if ( c.x86_model ==2)
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/acpi.c@92
PS15, Line 92: 	else
else is not generally useful after a break or return


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c
File src/cpu/intel/speedstep/speedstep.c:

https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@45
PS15, Line 45: 		if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and
line over 80 characters


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@46
PS15, Line 46: 									 enabled bits */
line over 80 characters


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@48
PS15, Line 48: 			params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask);
line over 80 characters


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@52
PS15, Line 52:         }
code indent should use tabs where possible


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@52
PS15, Line 52:         }
please, no spaces at the start of a line


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@73
PS15, Line 73: 	if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) {
suspect code indent for conditional statements (8, 8)


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@77
PS15, Line 77: 				!(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) {
line over 80 characters


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@79
PS15, Line 79: 			params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask);
line over 80 characters


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@82
PS15, Line 82:         }
code indent should use tabs where possible


https://review.coreboot.org/#/c/22604/15/src/cpu/intel/speedstep/speedstep.c@82
PS15, Line 82:         }
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/22604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a
Gerrit-Change-Number: 22604
Gerrit-PatchSet: 15
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 20 Jul 2018 11:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180720/464c824d/attachment.html>