[coreboot-gerrit] Change in coreboot[master]: Signed-off-by: Matt Wells <dawells at google.com>

David Wells (Code Review) gerrit at coreboot.org
Thu Jul 19 20:54:34 CEST 2018


David Wells has uploaded this change for review. ( https://review.coreboot.org/27552


Change subject: Signed-off-by: Matt Wells <dawells at google.com>
......................................................................

Signed-off-by: Matt Wells <dawells at google.com>

Update I2C timing for GRUNT

Update I2C timing for GRUNT using measurements taken from GRUNT EVT

Change-Id: Ie164dbc478b6dc525a07aec83550f3844ba53068
---
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/27552/1

diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 3863100..a5229b4 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -24,30 +24,30 @@
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 95,
-		.fall_time_ns = 3,
+		.rise_time_ns = 151,
+		.fall_time_ns = 50,
 	}"
 
 	# Enable I2C1 for H1 at 400kHz
 	register "i2c[1]" = "{
 		.early_init = 1,
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 84,
-		.fall_time_ns = 4,
+		.rise_time_ns = 62,
+		.fall_time_ns = 2,
 	}"
 
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 117,
-		.fall_time_ns = 113,
+		.rise_time_ns = 170,
+		.fall_time_ns = 91,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz
 	register "i2c[3]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 82,
-		.fall_time_ns = 67,
+		.rise_time_ns = 84,
+		.fall_time_ns = 50,
 	}"
 
 	device cpu_cluster 0 on

-- 
To view, visit https://review.coreboot.org/27552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie164dbc478b6dc525a07aec83550f3844ba53068
Gerrit-Change-Number: 27552
Gerrit-PatchSet: 1
Gerrit-Owner: David Wells <dawells at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180719/d3209e53/attachment.html>


More information about the coreboot-gerrit mailing list