[coreboot-gerrit] Change in coreboot[master]: google/cave: Add as a variant of glados

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27420 )

Change subject: google/cave: Add as a variant of glados
......................................................................


Patch Set 4:

(13 comments)

https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
File src/mainboard/google/glados/variants/cave/include/variant/gpio.h:

https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@97
PS4, Line 97: /* SRCCLKREQ0# */	PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TRACKPAD WAKE */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@108
PS4, Line 108: /* GSPI0_CLK */		PAD_CFG_GPI_ACPI_SCI(GPP_B16, NONE, DEEP, YES), /* WLAN WAKE */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@122
PS4, Line 122: /* SM1CLK */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C6, 20K_PU, DEEP), /* EC_IN_RW */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@128
PS4, Line 128: /* UART1_RXD */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), /* MEM_CONFIG[0] */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@129
PS4, Line 129: /* UART1_TXD */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C13, NONE, DEEP), /* MEM_CONFIG[1] */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@130
PS4, Line 130: /* UART1_RTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C14, NONE, DEEP), /* MEM_CONFIG[2] */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@131
PS4, Line 131: /* UART1_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C15, NONE, DEEP), /* MEM_CONFIG[3] */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@139
PS4, Line 139: /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@167
PS4, Line 167: /* CPU_GP0 */		PAD_CFG_GPI_GPIO_DRIVER(GPP_E3, NONE, DEEP), /* AUDIO_DB_ID */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@171
PS4, Line 171: /* CPU_GP1 */		PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST), /* TOUCHSCREEN */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@179
PS4, Line 179: /* DDPD_HPD2 */		PAD_CFG_GPI_ACPI_SMI(GPP_E15, NONE, DEEP, YES), /* EC_SMI_L */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@180
PS4, Line 180: /* DDPE_HPD3 */		PAD_CFG_GPI_ACPI_SCI(GPP_E16, NONE, DEEP, YES), /* EC_SCI_L */
line over 80 characters


https://review.coreboot.org/#/c/27420/4/src/mainboard/google/glados/variants/cave/include/variant/gpio.h@241
PS4, Line 241: /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27420
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c5181ce68f7a24ccd49f53ecd9d48c081fd085a
Gerrit-Change-Number: 27420
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 15:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180719/ee86cb7b/attachment.html>