[coreboot-gerrit] Change in coreboot[master]: google/asuka: Add as a variant of glados

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Jul 19 17:12:43 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27421 )

Change subject: google/asuka: Add as a variant of glados
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/27421/4/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
File src/mainboard/google/glados/variants/asuka/include/variant/gpio.h:

https://review.coreboot.org/#/c/27421/4/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@93
PS4, Line 93: /* SRCCLKREQ0# */	PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27421
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I591578fea2514a28c75177835807c3f250904577
Gerrit-Change-Number: 27421
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 19 Jul 2018 15:12:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180719/456aade8/attachment.html>


More information about the coreboot-gerrit mailing list