[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Add GPIO support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27417 )

Change subject: mediatek/mt8183: Add GPIO support
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/27417/6/src/soc/mediatek/mt8183/include/soc/gpio.h
File src/soc/mediatek/mt8183/include/soc/gpio.h:

https://review.coreboot.org/#/c/27417/6/src/soc/mediatek/mt8183/include/soc/gpio.h@44
PS6, Line 44: #define PIN(id, name, flag, bit, base, offset, \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/27417
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b0d88e9b70c9ad148797d77dc9e79ce1bcb64a
Gerrit-Change-Number: 27417
Gerrit-PatchSet: 6
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte at chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ting Shen <phoenixshen at google.com>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 18 Jul 2018 13:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180718/1e8c619b/attachment.html>