[coreboot-gerrit] Change in coreboot[master]: mediatek: Share GPIO code among similar SOCs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27416 )

Change subject: mediatek: Share GPIO code among similar SOCs
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/27416/4/src/soc/mediatek/mt8173/include/soc/gpio.h
File src/soc/mediatek/mt8173/include/soc/gpio.h:

https://review.coreboot.org/#/c/27416/4/src/soc/mediatek/mt8173/include/soc/gpio.h@38
PS4, Line 38: #define PIN(id, name, func1, func2, func3, func4, func5, func6, func7) \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/27416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0
Gerrit-Change-Number: 27416
Gerrit-PatchSet: 4
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte at chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ting Shen <phoenixshen at google.com>
Gerrit-Reviewer: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 14:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180717/f75e2183/attachment.html>