[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Fix gpio_set function

Marc Jones (Code Review) gerrit at coreboot.org
Sun Jul 15 01:46:29 CEST 2018


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27484


Change subject: soc/amd/stoneyridge: Fix gpio_set function
......................................................................

soc/amd/stoneyridge: Fix gpio_set function

The gpio_set function was not writing the correct GPIO register
address.

Change-Id: Ib306773ac72505977b606836bbaf3e2067324894
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/stoneyridge/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/27484/1

diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c
index 6513476..88e7d3b 100644
--- a/src/soc/amd/stoneyridge/gpio.c
+++ b/src/soc/amd/stoneyridge/gpio.c
@@ -162,7 +162,7 @@
 	reg = read32((void *)gpio_address);
 	reg &= ~GPIO_OUTPUT_MASK;
 	reg |=  !!value << GPIO_OUTPUT_SHIFT;
-	write32((void *)(uintptr_t)gpio_num, reg);
+	write32((void *)(uintptr_t)gpio_address, reg);
 }
 
 void gpio_input_pulldown(gpio_t gpio_num)

-- 
To view, visit https://review.coreboot.org/27484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib306773ac72505977b606836bbaf3e2067324894
Gerrit-Change-Number: 27484
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180714/bd4d346f/attachment.html>


More information about the coreboot-gerrit mailing list