[coreboot-gerrit] Change in coreboot[master]: libpayload/xhci: Check noop return code when debugging

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27478 )

Change subject: libpayload/xhci: Check noop return code when debugging
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27478/1/payloads/libpayload/drivers/usb/xhci.c
File payloads/libpayload/drivers/usb/xhci.c:

https://review.coreboot.org/#/c/27478/1/payloads/libpayload/drivers/usb/xhci.c@411
PS1, Line 411: 			fatal("noop command failed.\n");
I'm not sure die() is the right move here. This is just a debugging feature anyway, it shouldn't matter for production firmware. For debugging on early bring-up boards, I've seen plenty of cases where there was some kind of error here but the system was still usable afterwards (e.g. in case you didn't want to boot from USB, or if only one of several USB controllers was broken somehow). I'm fine with adding the condition code to the message if you want, but I don't think it should hang.



-- 
To view, visit https://review.coreboot.org/27478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa0b2fb087f5f0a36ba017a774fc98b33ab035a4
Gerrit-Change-Number: 27478
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Fri, 13 Jul 2018 22:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180713/465b87c3/attachment.html>