[coreboot-gerrit] Change in coreboot[master]: libpayload/generic_hub: Detect port disconnect after reset

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27477 )

Change subject: libpayload/generic_hub: Detect port disconnect after reset
......................................................................


Patch Set 1:

I don't understand what this patch is needed for. The general concept for libpayload's USB stack is that the payload keeps calling usb_poll() in regular intervals. So if a device transforms upon reset like this, the new SuperSpeed port should just get enumerated as part of the next usb_poll(). Why do we need to add a bunch of custom code to enumerate it right now? Calling code should generally not be written in a way that relies on all USB devices being enumerated immediately with the first usb_poll().


-- 
To view, visit https://review.coreboot.org/27477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad899544684312df1bef08d69b5c7f41eac3a21c
Gerrit-Change-Number: 27477
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Fri, 13 Jul 2018 22:28:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180713/aa6c336a/attachment.html>