[coreboot-gerrit] Change in coreboot[master]: libpayload: Add UNKNOWN_SPEED to usb_speed enum

Julius Werner (Code Review) gerrit at coreboot.org
Sat Jul 14 00:20:00 CEST 2018


Julius Werner has posted comments on this change. ( https://review.coreboot.org/27476 )

Change subject: libpayload: Add UNKNOWN_SPEED to usb_speed enum
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27476/1/payloads/libpayload/drivers/usb/generic_hub.c
File payloads/libpayload/drivers/usb/generic_hub.c:

https://review.coreboot.org/#/c/27476/1/payloads/libpayload/drivers/usb/generic_hub.c@174
PS1, Line 174: 			  speed);
usb_attach_device() already reports this in a human-readable way, so I don't think you really need it here.



-- 
To view, visit https://review.coreboot.org/27476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98a373717d52dfb6ca4dcc53a00dc1b4c240a919
Gerrit-Change-Number: 27476
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Fri, 13 Jul 2018 22:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180713/338ca58a/attachment.html>


More information about the coreboot-gerrit mailing list