[coreboot-gerrit] Change in coreboot[master]: cavium/bdk: Poke the watchdog while PCIe init

Patrick Rudolph (Code Review) gerrit at coreboot.org
Thu Jul 12 16:01:39 CEST 2018


Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27455


Change subject: cavium/bdk: Poke the watchdog while PCIe init
......................................................................

cavium/bdk: Poke the watchdog while PCIe init

Prevent a reboot loop due to slow PCIe init.
Poke the watchdog a few times.

Change-Id: I03739d7dbad3072ccf77364fa4caba42c66ac643
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
---
M src/vendorcode/cavium/bdk/libbdk-boot/bdk-boot-pcie.c
M src/vendorcode/cavium/bdk/libbdk-hal/bdk-pcie-cn8xxx.c
2 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/27455/1

diff --git a/src/vendorcode/cavium/bdk/libbdk-boot/bdk-boot-pcie.c b/src/vendorcode/cavium/bdk/libbdk-boot/bdk-boot-pcie.c
index b03c2e0..d52d6e9 100644
--- a/src/vendorcode/cavium/bdk/libbdk-boot/bdk-boot-pcie.c
+++ b/src/vendorcode/cavium/bdk/libbdk-boot/bdk-boot-pcie.c
@@ -61,6 +61,7 @@
                 {
                     BDK_TRACE(INIT, "Initializing PCIe%d on Node %d\n", p, n);
                     bdk_pcie_rc_initialize(n, p);
+                    bdk_watchdog_poke();
                 }
             }
         }
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-pcie-cn8xxx.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-pcie-cn8xxx.c
index 16034d2..6675fd5 100644
--- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-pcie-cn8xxx.c
+++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-pcie-cn8xxx.c
@@ -549,6 +549,7 @@
             return val;
         /* Failed, wait a little and try again */
         bdk_wait_usec(10000);
+        bdk_watchdog_poke();
     } while (bdk_clock_get_count(BDK_CLOCK_TIME) < timeout);
 
     BDK_TRACE(PCIE, "N%d.PCIe%d: Config read failed, can't communicate with device\n",
@@ -1123,6 +1124,7 @@
             return -1;
         }
         retry_count++;
+        bdk_watchdog_poke();
     }
 
     /* Errata PCIE-28816: Link retrain initiated at GEN1 can cause PCIE

-- 
To view, visit https://review.coreboot.org/27455
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03739d7dbad3072ccf77364fa4caba42c66ac643
Gerrit-Change-Number: 27455
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180712/41e64eab/attachment-0001.html>


More information about the coreboot-gerrit mailing list