[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN

[Tomasz Figa (Code Review)]

Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27433 )

Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@181
PS2, Line 181: PAD_CFG_NC(GPP_D8),
> I left GPP_D8 configured in gpio. […]
However, just keeping GPP_D8 configured here, without the relevant ACPI code configuring the pin correctly for kernel PM requests, doesn't actually allow camera development.

Given that, we can either
1) just clean it up now
or
2) try to make the ACPI code handle both variants.

2) could actually make some sense, if it doesn't introduce any side effects, since it may take quite a while until all the camera people get the new revision.



-- 
To view, visit https://review.coreboot.org/27433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e
Gerrit-Change-Number: 27433
Gerrit-PatchSet: 2
Gerrit-Owner: Ricky Liang <jcliang at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Ricky Liang <jcliang at chromium.org>
Gerrit-Reviewer: Tomasz Figa <tfiga at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 12 Jul 2018 03:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180712/f5136a09/attachment.html>