[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27433 )

Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h
File src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h:

https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h@a44
PS1, Line 44: 
> Is GPP_D8 not connected now? You will have to configure it accordingly in gpio.c: https://review. […]
I left GPP_D8 configured in gpio.c on purpose, to allow camera development on preEVT2 devices as well as EVT2.  GPP_D8 is a NC in EVT2, and GPP_B4 is a NC in preEVT2, so it should be safe.  I filed a reminder bug for cleanup once we're ready to obsolete preEVT2 (https://b.corp.google.com/issues/110066750)



-- 
To view, visit https://review.coreboot.org/27433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e
Gerrit-Change-Number: 27433
Gerrit-PatchSet: 1
Gerrit-Owner: Ricky Liang <jcliang at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Ricky Liang <jcliang at chromium.org>
Gerrit-Reviewer: Tomasz Figa <tfiga at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 20:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180711/34de21ef/attachment.html>