[coreboot-gerrit] Change in coreboot[master]: uart/sifive: provide a monotonic timer using CLINT timer register

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Jul 11 14:00:46 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27434 )

Change subject: uart/sifive: provide a monotonic timer using CLINT timer register
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27434/1/src/soc/sifive/fu540/timer.c
File src/soc/sifive/fu540/timer.c:

https://review.coreboot.org/#/c/27434/1/src/soc/sifive/fu540/timer.c@20
PS1, Line 20: #define CLINT_MTIME CLINT_BASE + 0xbff8
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/27434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5139601226e6f89da69e302a10f2fb56b4b24f38
Gerrit-Change-Number: 27434
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 12:00:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180711/991a15e4/attachment.html>


More information about the coreboot-gerrit mailing list