[coreboot-gerrit] Change in coreboot[master]: riscv: add spin lock support

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Jul 10 15:59:46 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27356 )

Change subject: riscv: add spin lock support
......................................................................


Patch Set 12:

(1 comment)

https://review.coreboot.org/#/c/27356/12/src/arch/riscv/include/arch/smp/spinlock.h
File src/arch/riscv/include/arch/smp/spinlock.h:

https://review.coreboot.org/#/c/27356/12/src/arch/riscv/include/arch/smp/spinlock.h@29
PS12, Line 29: 	while (atomic_swap(&lock->lock, -1));
trailing statements should be on next line



-- 
To view, visit https://review.coreboot.org/27356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e93fb8b35c4452f0fe3f7f4bcc6f7aa4e042451
Gerrit-Change-Number: 27356
Gerrit-PatchSet: 12
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 13:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180710/059169ab/attachment.html>


More information about the coreboot-gerrit mailing list