[coreboot-gerrit] Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas

[Ping-chung Chen (Code Review)]

Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 )

Change subject: mb/google/atlas: MIPI camera ASL files for Atlas
......................................................................


Patch Set 6:

(3 comments)

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@43
PS5, Line 43: 
> Please remove these comments
Done


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@44
PS5, Line 44: 
> Ditto
Done


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl@18
PS5, Line 18: 	/* Define the port for CIO2 device where endpoint of port0
            : 	is connected to CAM0 */
> Please fix these comments as Atlas uses a single camera.
Done



-- 
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 6
Gerrit-Owner: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh at intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang at intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen at intel.com>
Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 10 Jul 2018 02:36:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180710/99e9ec6d/attachment.html>