[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Add additional SPDs for variants

Daniel Kurtz (Code Review) gerrit at coreboot.org
Mon Jul 9 22:37:51 CEST 2018


Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27422 )

Change subject: mainboard/google/kahlee: Add additional SPDs for variants
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27422/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27422/1//COMMIT_MSG@9
PS1, Line 9: :111079089, b:111079089
These two are the same.


https://review.coreboot.org/#/c/27422/1/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc
File src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc:

https://review.coreboot.org/#/c/27422/1/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc@26
PS1, Line 26: micron-MTA4ATF51264HZ-2G6E1
Should this be:

 micron-MT40A512M16JY-083E-B



-- 
To view, visit https://review.coreboot.org/27422
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb03a3fa0842f7f89bb8c66dedbb8a0b293569be
Gerrit-Change-Number: 27422
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Jul 2018 20:37:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/79d3ff3d/attachment.html>


More information about the coreboot-gerrit mailing list