[coreboot-gerrit] Change in coreboot[master]: src/southbridge: Use "foo *bar" instead of "foo* bar"

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27409 )

Change subject: src/southbridge: Use "foo *bar" instead of "foo* bar"
......................................................................


Patch Set 2:

(9 comments)

https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb800/Amd.h
File src/southbridge/amd/cimx/sb800/Amd.h:

https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb800/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2,
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb800/Amd.h@66
PS2, Line 66: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void *ConfigPtr);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb800/Amd.h@67
PS2, Line 67: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void *ConfigPtr);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb900/Amd.h
File src/southbridge/amd/cimx/sb900/Amd.h:

https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb900/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2,
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb900/Amd.h@66
PS2, Line 66: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void *ConfigPtr);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/cimx/sb900/Amd.h@67
PS2, Line 67: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void *ConfigPtr);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/sr5650/sr5650.c
File src/southbridge/amd/sr5650/sr5650.c:

https://review.coreboot.org/#/c/27409/2/src/southbridge/amd/sr5650/sr5650.c@35
PS2, Line 35: struct resource *sr5650_retrieve_cpu_mmio_resource() {
open brace '{' following function declarations go on the next line


https://review.coreboot.org/#/c/27409/2/src/southbridge/intel/i82870/ioapic.c
File src/southbridge/intel/i82870/ioapic.c:

https://review.coreboot.org/#/c/27409/2/src/southbridge/intel/i82870/ioapic.c@47
PS2, Line 47: 	volatile uint32_t *pIndexRegister;    /* io apic io memory space command address */
line over 80 characters


https://review.coreboot.org/#/c/27409/2/src/southbridge/intel/i82870/ioapic.c@48
PS2, Line 48: 	volatile uint32_t *pWindowRegister;    /* io apic io memory space data address */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27409
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72d50615d77b91529810e8f590fa56f3c6f7546c
Gerrit-Change-Number: 27409
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 08 Jul 2018 10:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180708/30261ce9/attachment.html>