[coreboot-gerrit] Change in coreboot[master]: src/{device, drivers}: Use "foo *bar" instead of "foo* bar"

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27404 )

Change subject: src/{device,drivers}: Use "foo *bar" instead of "foo* bar"
......................................................................


Patch Set 1:

(36 comments)

https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h
File src/device/oprom/yabel/compat/of.h:

https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@38
PS1, Line 38: #define p32cast (int) (unsigned long) (void *)
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@53
PS1, Line 53: phandle_t of_peer(phandle_t);
function definition argument 'phandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@54
PS1, Line 54: phandle_t of_child(phandle_t);
function definition argument 'phandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@55
PS1, Line 55: phandle_t of_parent(phandle_t);
function definition argument 'phandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@56
PS1, Line 56: int of_getprop(phandle_t, const char *, void *, int);
function definition argument 'phandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@56
PS1, Line 56: int of_getprop(phandle_t, const char *, void *, int);
function definition argument 'const char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@56
PS1, Line 56: int of_getprop(phandle_t, const char *, void *, int);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@56
PS1, Line 56: int of_getprop(phandle_t, const char *, void *, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@57
PS1, Line 57: void *of_call_method_3(const char *, ihandle_t, int);
function definition argument 'const char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@57
PS1, Line 57: void *of_call_method_3(const char *, ihandle_t, int);
function definition argument 'ihandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@57
PS1, Line 57: void *of_call_method_3(const char *, ihandle_t, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@60
PS1, Line 60: ihandle_t of_open(const char *);
function definition argument 'const char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@62
PS1, Line 62: int of_read(ihandle_t, void *, int);
function definition argument 'ihandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@62
PS1, Line 62: int of_read(ihandle_t, void *, int);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@62
PS1, Line 62: int of_read(ihandle_t, void *, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@63
PS1, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'ihandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@63
PS1, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@63
PS1, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@64
PS1, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'ihandle_t' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@64
PS1, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@64
PS1, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@66
PS1, Line 66: void *of_claim(void *, unsigned int, unsigned int);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@66
PS1, Line 66: void *of_claim(void *, unsigned int, unsigned int);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@66
PS1, Line 66: void *of_claim(void *, unsigned int, unsigned int);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@67
PS1, Line 67: void of_release(void *, unsigned int);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@67
PS1, Line 67: void of_release(void *, unsigned int);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@70
PS1, Line 70: void *of_set_callback(void *);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@72
PS1, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@72
PS1, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@72
PS1, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@73
PS1, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@73
PS1, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@73
PS1, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@74
PS1, Line 74: int write_mm_log(char *, unsigned int, unsigned short);
function definition argument 'char *' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@74
PS1, Line 74: int write_mm_log(char *, unsigned int, unsigned short);
function definition argument 'unsigned int' should also have an identifier name


https://review.coreboot.org/#/c/27404/1/src/device/oprom/yabel/compat/of.h@74
PS1, Line 74: int write_mm_log(char *, unsigned int, unsigned short);
function definition argument 'unsigned short' should also have an identifier name



-- 
To view, visit https://review.coreboot.org/27404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c9b1edd8d3206a68854107ddcbc5c51cb487c3
Gerrit-Change-Number: 27404
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 08 Jul 2018 10:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180708/fbcccb8d/attachment.html>