[coreboot-gerrit] Change in coreboot[master]: pnp_device: improve readability

Felix Held (Code Review) gerrit at coreboot.org
Fri Jul 6 19:46:56 CEST 2018


Hello build bot (Jenkins), Nico Huber, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/27384

to look at the new patch set (#2).

Change subject: pnp_device: improve readability
......................................................................

pnp_device: improve readability

Add comments on the ops handling in pnp_enable_devices function and the
pnp_info struct.
Also remove the negation in the check if an LDN-specific override is used.
This patch doesn't change the logic though.

Change-Id: I3e80dbce1f29ee3e95e3b1d71c9b8479561d5c1a
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/device/pnp_device.c
M src/include/device/pnp.h
2 files changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/27384/2
-- 
To view, visit https://review.coreboot.org/27384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e80dbce1f29ee3e95e3b1d71c9b8479561d5c1a
Gerrit-Change-Number: 27384
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180706/6411dd41/attachment.html>


More information about the coreboot-gerrit mailing list