[coreboot-gerrit] Change in coreboot[master]: mb/intel/d945gclf/romstage.c: Remove unneeded includes

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Jul 6 14:59:19 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27345 )

Change subject: mb/intel/d945gclf/romstage.c: Remove unneeded includes
......................................................................

mb/intel/d945gclf/romstage.c: Remove unneeded includes

Change-Id: I3bdb93e51cabbfc14fe992ccdb6556e344e03c2f
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/27345
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/intel/d945gclf/romstage.c
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved



diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c
index 27c1e3e..57f32c2 100644
--- a/src/mainboard/intel/d945gclf/romstage.c
+++ b/src/mainboard/intel/d945gclf/romstage.c
@@ -16,17 +16,12 @@
 // __PRE_RAM__ means: use "unsigned" for device, not a struct.
 
 #include <stdint.h>
-#include <string.h>
-#include <arch/io.h>
 #include <device/pci_def.h>
+#include <arch/io.h>
 #include <device/pnp_def.h>
 #include <cpu/x86/lapic.h>
-#include <lib.h>
-#include <arch/acpi.h>
-#include <cbmem.h>
 #include <timestamp.h>
 #include <superio/smsc/lpc47m15x/lpc47m15x.h>
-#include <pc80/mc146818rtc.h>
 #include <console/console.h>
 #include <cpu/x86/bist.h>
 #include <cpu/intel/romstage.h>

-- 
To view, visit https://review.coreboot.org/27345
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bdb93e51cabbfc14fe992ccdb6556e344e03c2f
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180706/491c68f6/attachment.html>


More information about the coreboot-gerrit mailing list