[coreboot-gerrit] Change in coreboot[master]: google: Use proper ACPI ID for Semtech chips: STH

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Jul 6 14:58:26 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27347 )

Change subject: google: Use proper ACPI ID for Semtech chips: STH
......................................................................

google: Use proper ACPI ID for Semtech chips: STH

Change-Id: I85cd567a923cccd2504f351aae276b5f0d9db4de
Signed-off-by: Gwendal Grignou <gwendal at chromium.org>
Reviewed-on: https://review.coreboot.org/27347
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Matt Delco <delco at google.com>
Reviewed-by: Seunghwan Kim <sh_.kim at samsung.com>
Reviewed-by: Furquan Shaikh <furquan at google.com>
---
M src/drivers/i2c/sx9310/sx9310.c
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
M src/mainboard/google/zoombini/variants/meowth/devicetree.cb
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Seunghwan Kim: Looks good to me, but someone else must approve
  Matt Delco: Looks good to me, but someone else must approve



diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c
index 5f63734..3443f5c 100644
--- a/src/drivers/i2c/sx9310/sx9310.c
+++ b/src/drivers/i2c/sx9310/sx9310.c
@@ -22,7 +22,7 @@
 #include <string.h>
 #include "chip.h"
 
-#define I2C_SX9310_ACPI_ID	"SX9310"
+#define I2C_SX9310_ACPI_ID	"STH9310"
 #define I2C_SX9310_ACPI_NAME	"Semtech SX9310"
 
 #define REGISTER(NAME) acpi_dp_add_integer(dsd, \
diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index 68246c6..b2617e5 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -330,7 +330,7 @@
 		end # I2C #1
 		device pci 15.2 on
 			chip drivers/i2c/generic
-				register "hid" = ""SX9321""
+				register "hid" = ""STH9321""
 				register "name" = ""SEMTECH SX9321""
 				register "desc" = ""SAR Proximity Sensor""
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A18_IRQ)"
diff --git a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb
index adeedea..bbff695 100644
--- a/src/mainboard/google/zoombini/variants/meowth/devicetree.cb
+++ b/src/mainboard/google/zoombini/variants/meowth/devicetree.cb
@@ -107,7 +107,7 @@
 		end # I2C #0
 		device pci 15.1 on
 			chip drivers/i2c/generic
-				register "hid" = ""SX9310""
+				register "hid" = ""STH9310""
 				register "name" = ""SEMTECH SX9310""
 				register "desc" = ""Left SAR Proximity Sensor""
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C3_IRQ)"
@@ -145,7 +145,7 @@
 		device pci 19.0 on  end # I2C #4
 		device pci 19.1 on
 			chip drivers/i2c/generic
-				register "hid" = ""SX9310""
+				register "hid" = ""STH9310""
 				register "name" = ""SEMTECH SX9310""
 				register "desc" = ""Right SAR Proximity Sensor""
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C4_IRQ)"

-- 
To view, visit https://review.coreboot.org/27347
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I85cd567a923cccd2504f351aae276b5f0d9db4de
Gerrit-Change-Number: 27347
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Matt Delco <delco at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180706/3ed0697e/attachment.html>


More information about the coreboot-gerrit mailing list