[coreboot-gerrit] Change in coreboot[master]: mainboard/broadcom/blast: Rmove not necessary braces {}

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Wed Jan 31 23:13:09 CET 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23523


Change subject: mainboard/broadcom/blast: Rmove not necessary braces {}
......................................................................

mainboard/broadcom/blast: Rmove not necessary braces {}

Also, add required space before opening parenthesis '('

Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/broadcom/blast/mptable.c
1 file changed, 10 insertions(+), 19 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/23523/1

diff --git a/src/mainboard/broadcom/blast/mptable.c b/src/mainboard/broadcom/blast/mptable.c
index 2417c96..854e255 100644
--- a/src/mainboard/broadcom/blast/mptable.c
+++ b/src/mainboard/broadcom/blast/mptable.c
@@ -36,7 +36,7 @@
 	{
 		device_t dev = 0;
 		struct resource *res;
-		for(i = 0; i < 3; i++) {
+		for (i = 0; i < 3; i++) {
 			dev = dev_find_device(0x1166, 0x0235, dev);
 			if (dev) {
 				res = find_resource(dev, PCI_BASE_ADDRESS_0);
@@ -63,9 +63,8 @@
 
 //USB
 	outb(0x01, 0xc00); outb(0x0a, 0xc01);
-	for(i = 0; i < 3; i++) {
+	for (i = 0; i < 3; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, ((2+sysconf.sbdn)<<2)|i, apicid_bcm5785[0], 0xa); //
-	}
 
 
 
@@ -85,51 +84,43 @@
 	}
 
 //First pci-x slot (on bcm5785) under bus_bcm5785_1:d.0
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_1_1, (4 << 2)|i, apicid_bcm5785[1], 2 + (0+i)%4); //
-	}
 
 
 //pci slot (on bcm5785)
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, (4 << 2)|i, apicid_bcm5785[1], i%2); //
-	}
 
 
 //onboard ati
 	smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, (5 << 2)|0, apicid_bcm5785[1], 0x1);
 
 //PCI-X on bcm5780
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[1], (4 << 2)|i, apicid_bcm5785[1], 6 + (0+i)%4); //
-	}
 
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[1], (5 << 2)|i, apicid_bcm5785[1], 6 + (1+i)%4); //
-	}
 
 //onboard Broadcom
-	for(i = 0; i < 2; i++) {
+	for (i = 0; i < 2; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[2], (4 << 2)|i, apicid_bcm5785[1], 0xa + (0+i)%4); //
-	}
 
 
 // First PCI-E x8
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[5], (0 << 2)|i, apicid_bcm5785[1], 0xe); //
-	}
 
 
 // Second PCI-E x8
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[3], (0 << 2)|i, apicid_bcm5785[1], 0xc); //
-	}
 
 
 // Third PCI-E x1
-	for(i = 0; i < 4; i++) {
+	for (i = 0; i < 4; i++)
 		smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[4], (0 << 2)|i, apicid_bcm5785[1], 0xd); //
-	}
 
 /*Local Ints:	Type	Polarity    Trigger	Bus ID	 IRQ	APIC ID	PIN#*/
 	mptable_lintsrc(mc, bus_isa);

-- 
To view, visit https://review.coreboot.org/23523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d
Gerrit-Change-Number: 23523
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180131/918f4563/attachment.html>


More information about the coreboot-gerrit mailing list