[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...

[Lin Huang (Code Review)]

Lin Huang has posted comments on this change. ( https://review.coreboot.org/23515 )

Change subject: rockchip/rk3399: add the delay time between saradc power up and start command
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c
File src/soc/rockchip/rk3399/saradc.c:

https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74
PS1, Line 74: 	udelay(SARADC_DELAY_PU);
> Please test multiple combinations (e.g. 4MHz 2 samples, 8MHz 4 samples, etc. […]
Hmm, i do not have the device can repro this issue, i ask　manufacturer　help to test, and if want to repro this issue, need to put the device into 0C ambient tempterature　for 3 or 4 hours, so it may take long time to do the test. Anyway, we will try to do more test.



-- 
To view, visit https://review.coreboot.org/23515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42e49ca63299479912fa05e2a62cba6f2de4b337
Gerrit-Change-Number: 23515
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 31 Jan 2018 07:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180131/81e44d21/attachment.html>