[coreboot-gerrit] Change in coreboot[master]: security/tpm: Set up generic TSPI

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22106 )

Change subject: security/tpm: Set up generic TSPI
......................................................................


Patch Set 40:

(3 comments)

https://review.coreboot.org/#/c/22106/37/src/security/vboot/antirollback.h
File src/security/vboot/antirollback.h:

https://review.coreboot.org/#/c/22106/37/src/security/vboot/antirollback.h@60
PS37, Line 60: antirollb
> It's vboot specific in that it takes a struct vb2_context.
ah sorry missed that. Got it wrong will fix it as well.


https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c
File src/security/vboot/secdata_tpm.c:

https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c@67
PS39, Line 67: delete or modify once
             :  * the RO exits
> Note that thes attributes by themselves actually don't (and shouldn't) protect the spaces from modif […]
got it


https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c@206
PS39, Line 206: 
> As noted in the previous comment, I'd keep a different set of attributes and no delete policy for ke […]
Done



-- 
To view, visit https://review.coreboot.org/22106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb
Gerrit-Change-Number: 22106
Gerrit-PatchSet: 40
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Pronin <apronin at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Jan 2018 00:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180130/733f9a35/attachment.html>