[coreboot-gerrit] Change in coreboot[master]: autoport: Don't do write to FD

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Jan 29 10:52:36 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23486


Change subject: autoport: Don't do write to FD
......................................................................

autoport: Don't do write to FD

This is properly done in ramstage, so no need to do it in romstage.

Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M util/autoport/bd82x6x.go
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23486/1

diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index d342a79..c7862cf 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -336,12 +336,8 @@
 
 void rcba_config(void)
 {
-	/* Disable devices.  */
 `)
-	RestoreRCBA32(sb, inteltool, 0x3414)
-	RestoreRCBA32(sb, inteltool, 0x3418)
-
-	sb.WriteString("\n}\n")
+	sb.WriteString("}\n\n")
 
 	sb.WriteString("const struct southbridge_usb_port mainboard_usb_ports[] = {\n")
 

-- 
To view, visit https://review.coreboot.org/23486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Gerrit-Change-Number: 23486
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180129/f302f8f4/attachment.html>


More information about the coreboot-gerrit mailing list