[coreboot-gerrit] Change in coreboot[master]: inteltool: Fix displaying 64bit spi registers

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Jan 28 20:29:23 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23478


Change subject: inteltool: Fix displaying 64bit spi registers
......................................................................

inteltool: Fix displaying 64bit spi registers

The registers were taken from the wrong addess since the spibar offset
was not added to it.

Change-Id: I8bb91517770359599fe5f579c4686434da8d1c27
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M util/inteltool/spi.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/23478/1

diff --git a/util/inteltool/spi.c b/util/inteltool/spi.c
index cda8667..bd84995 100644
--- a/util/inteltool/spi.c
+++ b/util/inteltool/spi.c
@@ -279,7 +279,8 @@
 				printf("0x%08x = %s\n", *(uint32_t *)(rcba + spibaroffset + spi_register[i].addr), spi_register[i].name);
 				break;
 			case 8:
-				printf("0x%08x%08x = %s\n", *(uint32_t *)(rcba + spi_register[i].addr), *(uint32_t *)(rcba + spi_register[i].addr + 4), spi_register[i].name);
+				printf("0x%08x%08x = %s\n", *(uint32_t *)(rcba + spibaroffset + spi_register[i].addr),
+					*(uint32_t *)(rcba + spibaroffset + spi_register[i].addr + 4), spi_register[i].name);
 				break;
 		}
 	}

-- 
To view, visit https://review.coreboot.org/23478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bb91517770359599fe5f579c4686434da8d1c27
Gerrit-Change-Number: 23478
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180128/eaf350e1/attachment.html>


More information about the coreboot-gerrit mailing list