[coreboot-gerrit] Change in coreboot[master]: coreboot_tables: Comment struct lb_framebuffer
Nico Huber (Code Review)
gerrit at coreboot.org
Sat Jan 27 16:54:33 CET 2018
Hello Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23466
to look at the new patch set (#2).
Change subject: coreboot_tables: Comment struct lb_framebuffer
......................................................................
coreboot_tables: Comment struct lb_framebuffer
Try to clarify `bytes_per_line`. This was ignored in CorebootPayloadPkg
for some reason and led to some confusion.
Maybe we should document some of the other fields as well. I would have
thought, though, it's self-explanatory, but I also thought that about
`bytes_per_line`.
Change-Id: I5e1343b5fe37ac106e61e6907fbcc1737ac56f8b
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/commonlib/include/commonlib/coreboot_tables.h
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/23466/2
--
To view, visit https://review.coreboot.org/23466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e1343b5fe37ac106e61e6907fbcc1737ac56f8b
Gerrit-Change-Number: 23466
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180127/fbcdeed0/attachment.html>
More information about the coreboot-gerrit
mailing list