[coreboot-gerrit] Change in coreboot[master]: chromeec: Decouple EC tablet event and TBMC device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23461


Change subject: chromeec: Decouple EC tablet event and TBMC device
......................................................................

chromeec: Decouple EC tablet event and TBMC device

This change decouples EC tablet event and TBMC device by guarding
TBMC definition and notification using EC_ENABLE_TBMC_DEVICE. It
allows mainboards to use tablet events without having to define a TBMC
device.

BUG=b:72554519

Change-Id: Ie38b6d68486e8e644dd0d6d406def3ae7fdb5152
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/ec/google/chromeec/acpi/ec.asl
M src/mainboard/google/eve/ec.h
M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
4 files changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23461/1

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index d295a8d..618b00a 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -365,6 +365,8 @@
 		If (CondRefOf (\_SB.DPTF.TPET)) {
 			\_SB.DPTF.TPET()
 		}
+#endif
+#ifdef EC_ENABLE_TBMC_DEVICE
 		Notify (TBMC, 0x80)
 #endif
 	}
@@ -517,7 +519,7 @@
 	#include "pd.asl"
 #endif
 
-#ifdef EC_ENABLE_TABLET_EVENT
+#ifdef EC_ENABLE_TBMC_DEVICE
 	#include "tbmc.asl"
 #endif
 }
diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h
index 81d591c..1b55248 100644
--- a/src/mainboard/google/eve/ec.h
+++ b/src/mainboard/google/eve/ec.h
@@ -79,6 +79,8 @@
 /* Enable Tablet switch */
 #define EC_ENABLE_TABLET_EVENT
 
+#define EC_ENABLE_TBMC_DEVICE
+
 #define SIO_EC_MEMMAP_ENABLE	/* EC Memory Map Resources */
 #define SIO_EC_HOST_ENABLE	/* EC Host Interface Resources */
 #define SIO_EC_ENABLE_PS2K	/* Enable PS/2 Keyboard */
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
index ca9f865..70f12d5 100644
--- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
@@ -72,6 +72,7 @@
 #define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
 #define EC_ENABLE_TABLET_EVENT
+#define EC_ENABLE_TBMC_DEVICE
 
 #define SIO_EC_MEMMAP_ENABLE	/* EC Memory Map Resources */
 #define SIO_EC_HOST_ENABLE	/* EC Host Interface Resources */
diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
index 1f91c1e..ff32ff6 100644
--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
@@ -74,6 +74,8 @@
 /* Enable Tablet switch */
 #define EC_ENABLE_TABLET_EVENT
 
+#define EC_ENABLE_TBMC_DEVICE
+
 #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */
 #define SIO_EC_HOST_ENABLE       /* EC Host Interface Resources */
 #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */

-- 
To view, visit https://review.coreboot.org/23461
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie38b6d68486e8e644dd0d6d406def3ae7fdb5152
Gerrit-Change-Number: 23461
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180127/d10a2e50/attachment.html>