[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/soraka: Enable dynamic DPTF

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23463


Change subject: mb/google/poppy/variants/soraka: Enable dynamic DPTF
......................................................................

mb/google/poppy/variants/soraka: Enable dynamic DPTF

This change selects EC tablet event and provides trip point
temperatures for tablet and non-tablet mode so that dynamic DPTF can
be supported depending upon device mode.

BUG=b:65467566
TEST=Verified by changing modes that the trip point temperatures are
updated in the
OS (/sys/devices/virtual/thermal/thermal_zone{2,3,4,5}).

Change-Id: I071868982fa87821550b870a6d8050cf2a030b49
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl
M src/mainboard/google/poppy/variants/soraka/include/variant/ec.h
2 files changed, 29 insertions(+), 18 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23463/1

diff --git a/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl
index b854608..736bd13 100644
--- a/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl
@@ -14,28 +14,36 @@
  * GNU General Public License for more details.
  */
 
-#define DPTF_CPU_PASSIVE	85
-#define DPTF_CPU_CRITICAL	100
+#define DPTF_CPU_PASSIVE		85
+#define DPTF_CPU_CRITICAL		100
 
-#define DPTF_TSR0_SENSOR_ID	1
-#define DPTF_TSR0_SENSOR_NAME	"Ambient"
-#define DPTF_TSR0_PASSIVE	55
-#define DPTF_TSR0_CRITICAL	65
+#define DPTF_TSR0_SENSOR_ID		1
+#define DPTF_TSR0_SENSOR_NAME		"Ambient"
+#define DPTF_TSR0_PASSIVE		55
+#define DPTF_TSR0_CRITICAL		65
+#define DPTF_TSR0_TABLET_PASSIVE	55
+#define DPTF_TSR0_TABLET_CRITICAL	65
 
-#define DPTF_TSR1_SENSOR_ID	2
-#define DPTF_TSR1_SENSOR_NAME	"Charger"
-#define DPTF_TSR1_PASSIVE	58
-#define DPTF_TSR1_CRITICAL	70
+#define DPTF_TSR1_SENSOR_ID		2
+#define DPTF_TSR1_SENSOR_NAME		"Charger"
+#define DPTF_TSR1_PASSIVE		58
+#define DPTF_TSR1_CRITICAL		70
+#define DPTF_TSR1_TABLET_PASSIVE	60
+#define DPTF_TSR1_TABLET_CRITICAL	70
 
-#define DPTF_TSR2_SENSOR_ID	3
-#define DPTF_TSR2_SENSOR_NAME	"DRAM"
-#define DPTF_TSR2_PASSIVE	60
-#define DPTF_TSR2_CRITICAL	75
+#define DPTF_TSR2_SENSOR_ID		3
+#define DPTF_TSR2_SENSOR_NAME		"DRAM"
+#define DPTF_TSR2_PASSIVE		60
+#define DPTF_TSR2_CRITICAL		75
+#define DPTF_TSR2_TABLET_PASSIVE	58
+#define DPTF_TSR2_TABLET_CRITICAL	75
 
-#define DPTF_TSR3_SENSOR_ID	4
-#define DPTF_TSR3_SENSOR_NAME	"eMMC"
-#define DPTF_TSR3_PASSIVE	60
-#define DPTF_TSR3_CRITICAL	75
+#define DPTF_TSR3_SENSOR_ID		4
+#define DPTF_TSR3_SENSOR_NAME		"eMMC"
+#define DPTF_TSR3_PASSIVE		60
+#define DPTF_TSR3_CRITICAL		75
+#define DPTF_TSR3_TABLET_PASSIVE	58
+#define DPTF_TSR3_TABLET_CRITICAL	75
 
 #define DPTF_ENABLE_CHARGER
 
diff --git a/src/mainboard/google/poppy/variants/soraka/include/variant/ec.h b/src/mainboard/google/poppy/variants/soraka/include/variant/ec.h
index 047abb6..95e743f 100644
--- a/src/mainboard/google/poppy/variants/soraka/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/soraka/include/variant/ec.h
@@ -18,4 +18,7 @@
 
 #include <baseboard/ec.h>
 
+#define EC_ENABLE_TABLET_EVENT	/* Tablet event to support dynamic
+				   DPTF */
+
 #endif /* __MAINBOARD_EC_H__ */

-- 
To view, visit https://review.coreboot.org/23463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I071868982fa87821550b870a6d8050cf2a030b49
Gerrit-Change-Number: 23463
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180127/3337acaa/attachment-0001.html>